#31 handle Expires with Cache-Control

Kevinrob · Sep 6, 2015 · 9f9c7f9 · 9f9c7f9
1 parent ea0523a
commit 9f9c7f9
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/Strategy/PrivateCacheStrategy.php b/src/Strategy/PrivateCacheStrategy.php
@@ -106,6 +106,14 @@ protected function getCacheObjectForCacheControl(ResponseInterface $response, Ke
             return $entry->hasValidationInformation() ? $entry : null;
         }
 
+        if ($response->hasHeader("Expires")
+            && $expireAt = \DateTime::createFromFormat(\DateTime::RFC1123, $response->getHeaderLine("Expires"))) {
+            return new CacheEntry(
+                $response,
+                $expireAt
+            );
+        }
+
         foreach ($this->ageKey as $key) {
             if ($cacheControl->has($key)) {
                 return new CacheEntry(

diff --git a/tests/HeaderCacheControlTest.php b/tests/HeaderCacheControlTest.php
@@ -52,6 +52,12 @@ public function setUp()
                             ->withAddedHeader("Cache-Control", "no-cache")
                             ->withAddedHeader("Etag", "TheHash")
                     );
+                case '/2s-expires':
+                    return new FulfilledPromise(
+                        (new Response())
+                            ->withAddedHeader("Cache-Control", "public")
+                            ->withAddedHeader("Expires", gmdate('D, d M Y H:i:s T', time() + 2))
+                    );
             }
 
             throw new \InvalidArgumentException();
@@ -106,4 +112,17 @@ public function testNoCacheHeader()
         $this->assertEquals(CacheMiddleware::HEADER_CACHE_HIT, $response->getHeaderLine(CacheMiddleware::HEADER_CACHE_INFO));
     }
 
+    public function testWithExpires()
+    {
+        $this->client->get("http://test.com/2s-expires");
+
+        $response = $this->client->get("http://test.com/2s-expires");
+        $this->assertEquals(CacheMiddleware::HEADER_CACHE_HIT, $response->getHeaderLine(CacheMiddleware::HEADER_CACHE_INFO));
+
+        sleep(3);
+
+        $response = $this->client->get("http://test.com/2s-expires");
+        $this->assertEquals(CacheMiddleware::HEADER_CACHE_MISS, $response->getHeaderLine(CacheMiddleware::HEADER_CACHE_INFO));
+    }
+
 }