Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the bind point supplied to vkCmdBindDescriptorSets / vkCmdPushDescriptorSets #1898

Merged
merged 1 commit into from
May 12, 2023
Merged

Respect the bind point supplied to vkCmdBindDescriptorSets / vkCmdPushDescriptorSets #1898

merged 1 commit into from
May 12, 2023

Conversation

etang-cw
Copy link
Contributor

Prevents calls to vkCmdPushDescriptorSetKHR with layouts that specify VK_SHADER_STAGE_ALL from applying to things they shouldn't (e.g. having VK_PIPELINE_BIND_POINT_COMPUTE binds trash the graphics bindings)

@CLAassistant
Copy link

CLAassistant commented May 12, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

billhollings
billhollings reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you submission!

Before pulling this in, I'd like to get the questions below answered, regarding expanding this to other use cases later.

MoltenVK/MoltenVK/GPUObjects/MVKDescriptor.mm Outdated Show resolved Hide resolved
@etang-cw etang-cw force-pushed the PushBindPoint branch 2 times, most recently from 9612d76 to c36227e Compare May 12, 2023 17:58
@etang-cw etang-cw changed the title Respect the bind point supplied to vkCmdPushDescriptorSets Respect the bind point supplied to vkCmdBindDescriptorSets / vkCmdPushDescriptorSets May 12, 2023
billhollings
billhollings approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks!

@billhollings billhollings merged commit 734a185 into KhronosGroup:main May 12, 2023
6 checks passed
@etang-cw etang-cw deleted the PushBindPoint branch May 12, 2023 18:43
@etang-cw etang-cw mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhollings billhollings billhollings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etang-cw @CLAassistant @billhollings