Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation issue due to new project version #2185

Conversation

jeroenbakker-atmind
Copy link
Contributor

@jeroenbakker-atmind jeroenbakker-atmind commented Mar 14, 2024

MoltenVK has updated to a new version, but the build scripts still
mentioned the previous version, which failed during build.

MVKInstance.mm:774:2: error: 
      static assertion failed due to requirement 'std::string_view("1.2.8") ==
      ("1.2.9")': Xcode build setting CURRENT_PROJECT_VERSION must be identical
      to the MoltenVK version (MVK_VERSION_STRING).
  ...static_assert(string_view(MVK_STRINGIFY(MVK_FRAMEWORK_VERSION)) == MVK_VERSION_STRING...
     ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

This is fixed by updating the CURRENT_PROJECT_VERSION. Developers updating
should first clear their build folder (make clean) before the new changes become
into effect.

@jeroenbakker-atmind jeroenbakker-atmind changed the title Fix compilation issue due to new version Fix compilation issue due to new project version Mar 14, 2024
@billhollings
Copy link
Contributor

billhollings commented Mar 14, 2024

Ah. Thanks!

I hadn't compiled when I published the 1.2.9 version update. 🤦🏻‍♂️

At least this proves the value of that static assertion! 👍🏻

@billhollings billhollings merged commit 5c51d2a into KhronosGroup:main Mar 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants