Add option to dump shaders #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhollings
requested changes
Apr 15, 2024
| @@ -359,3 +359,10 @@ void mvkSetConfig(MVKConfiguration& dstMVKConfig, const MVKConfiguration& srcMVK | |||
|
|
|||
| #undef MVK_CONFIG__UNUSED_STRUCT_PADDING | |||
| #define MVK_CONFIG__UNUSED_STRUCT_PADDING 0 | |||
There was a problem hiding this comment.
These two line should be after everything else (per the padding discussion above).
There was a problem hiding this comment.
I've removed this now (I should have removed them on my PR).
etang-cw
force-pushed
the
ShaderDump
branch
2 times, most recently
from
33e1a20
to
f830f18
Compare
billhollings
requested changes
Apr 16, 2024
There was a problem hiding this comment.
As mentioned in the details, once PR #2211 has been pulled in, rebase this PR on the latest main.
billhollings
approved these changes
Apr 19, 2024
Aligning with syntax of other comments in this file.
Removing as obsolete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to dump shaders and pipelines to a directory
When enabled, it writes the spirv and resulting msl for every shader compiled to a file named by the spirv hash
Usually a bit easier to search through than trying to look through an MVK_DEBUG=1 log, especially for pipeline link failures