Added mechanism to trigger GPU capture without attaching a debugger. #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhollings
requested changes
May 29, 2024
cdavis5e
requested changes
May 30, 2024
| if (getMVKConfig().autoGPUCaptureScope == MVK_CONFIG_AUTO_GPU_CAPTURE_SCOPE_ON_DEMAND) { | ||
| char pipeName[] = "/tmp/MoltenVKCapturePipe-XXXXXXXXXX"; | ||
| mktemp(pipeName); | ||
| if (mkfifo(pipeName, 0600) < 0) { |
There was a problem hiding this comment.
If errno contains EEXIST, that means there was a collision and you should probably try this again with a new filename.
There was a problem hiding this comment.
Seems a little defensive to me, but fine.
js6i
force-pushed
the
gpu-capture-pipe
branch
2 times, most recently
from
21c83b6
to
84c0ef3
Compare
When MVK_CONFIG_AUTO_GPU_CAPTURE_SCOPE_ON_DEMAND is set, we will create a temporary named pipe, and try reading it on each present. When data is written to the pipe, for each byte that we read we will capture a single frame.
billhollings
approved these changes
May 30, 2024
cdavis5e
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally I want to capture a single GPU frame but have trouble attaching Xcode. I hacked in something of this sort several times already, so here it is cleaned up.