Fix shader conversion failure when using native texture atomics. #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdavis5e
approved these changes
May 30, 2024
- mvkPopulateShaderConversionConfig() VK_DESCRIPTOR_TYPE_STORAGE_IMAGE and VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, don't add buffer resource binding if native texture atomics are supported. - Remove MVKPhysicalDevice::useNativeTextureAtomics() and update all occurrences of getPhysicalDevice()->useNativeTextureAtomics() to getMetalFeatures().nativeTextureAtomics.
billhollings
force-pushed
the
fix-shdr-native-atomics
branch
from
f33ac58
to
f36e5a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvkPopulateShaderConversionConfig()VK_DESCRIPTOR_TYPE_STORAGE_IMAGEandVK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER, don't add buffer resource binding if native texture atomics are supported.MVKPhysicalDevice::useNativeTextureAtomics()and update all occurrences ofgetPhysicalDevice()->useNativeTextureAtomics()togetMetalFeatures().nativeTextureAtomics.Fixes issue #2180.