iOS: Support storage images in Metal argument buffers. #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS GPUs with Tier1 argument buffer support, Metal does not support writable textures in argument buffers. MoltenVK and SPIRV-Cross were addressing this differently. - Set CompilerMSL::Options::ArgumentBuffersTier to align behaviour between MoltenVK and SPIRV-Cross. - On iOS Tier1 GPUs, if a descriptor set contains a storage image, don't use a Metal argument buffer for that descriptor set.
billhollings
force-pushed
the
ios-storg-img-argbuffs
branch
from
bb476f5
to
c37a880
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS GPUs with Tier1 argument buffer support, Metal does not support writable textures in argument buffers. MoltenVK and SPIRV-Cross were addressing this differently.
CompilerMSL::Options::ArgumentBuffersTierto align behaviour between MoltenVK and SPIRV-Cross.