Support disabling logging GLSL shader code during shader conversion logging. #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogging. Logging estimated GLSL shader code by default clutters the log with info that is not necessarily helpful, and it can occasionally result in a crash during the generation of GLSL, even though the MSL is correctly generated. - Add MVKConfiguration::shaderLogEstimatedGLSL, and environment variable MVK_CONFIG_SHADER_LOG_ESTIMATED_GLSL, to enable or disable the logging of estimated GLSL code, and disable it by default. - Clean up alphabetic order of MoltenVK_Configuration_Parameters.md doc.
cdavis5e
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging estimated GLSL shader code by default clutters the log with info that is not necessarily helpful, and it can occasionally result in a crash during the generation of GLSL, even though the MSL is correctly generated.
MVKConfiguration::shaderLogEstimatedGLSL, and environment variableMVK_CONFIG_SHADER_LOG_ESTIMATED_GLSL, to enable or disable the logging of estimated GLSL code, and disable it by default.MoltenVK_Configuration_Parameters.mddoc.