Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updateMutableCommands template to use std::array::size() and const pointers #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

banan328
Copy link

@banan328 banan328 commented Sep 9, 2024

This pull request fixes this commit #298:

  • Replaced configs.length() with configs.size() to correctly retrieve the array size.
  • Changed configs to std::array<const void*, ArrayLength> for better const-correctness.
  • Passed config_types.data(), configs.data() directly to pfn_clUpdateMutableCommandsKHR.

@bashbaug
Copy link
Contributor

bashbaug commented Sep 9, 2024

Could you add a test for this function?

(It would have been good to do that previously, since it probably would have caught these bugs earlier.)

@EwanC
Copy link
Contributor

EwanC commented Sep 16, 2024

Could you add a test for this function?

(It would have been good to do that previously, since it probably would have caught these bugs earlier.)

There is an open PR #276 with some testing, will probably be a bit stale and need updated but could prioritize getting that in as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants