Skip to content

Commit

Permalink
Reduce the Vulkan interop buffer kernel workgroup size to 256
Browse files Browse the repository at this point in the history
Using `local_size_x = 512` in the shader used in the Vulkan interop
tests fails on older hardware because this exceeds the maximum barrier
size limit.

Changed to 256, which is still a multiple of 32 and 64,
and is below the hardware limitations. The tests are not performance
tests anyways, so the performance penalty, if any, is acceptable.

Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>
  • Loading branch information
ahesham-arm committed Oct 18, 2023
1 parent 40aaa2b commit a3fc027
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test_conformance/vulkan/shaders/buffer.comp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ layout(binding = 1) buffer Buffer
{
uint8_t ptr[];
} bufferPtrList[MAX_BUFFERS];
layout(local_size_x = 512) in;
layout(local_size_x = 256) in;
void main() {
for (uint32_t bufIdx = 0; bufIdx < numBuffers; bufIdx++) {
uint32_t ptrIdx = gl_GlobalInvocationID.x;
Expand Down
Binary file modified test_conformance/vulkan/shaders/buffer.spv
Binary file not shown.

0 comments on commit a3fc027

Please sign in to comment.