Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printf is incorrectly testing vector arguments #2039

Closed
coldav opened this issue Aug 7, 2024 · 4 comments · Fixed by #2044
Closed

printf is incorrectly testing vector arguments #2039

coldav opened this issue Aug 7, 2024 · 4 comments · Fixed by #2044

Comments

@coldav
Copy link

coldav commented Aug 7, 2024

#2019 added multiple vector tests including:

float3 tmp = (float3)(1234.25f,987654.5f,0.0005f); printf("%.2v3e\n",tmp);}

This does not include a length specifier. The spec says that "If a vector specifier appears without a length modifier, the behaviour is undefined. "

There are a few others like this.

@bashbaug
Copy link
Contributor

bashbaug commented Aug 7, 2024

Should we revert #2019 while we get this worked out? CC @shajder

svenvh added a commit to svenvh/OpenCL-CTS that referenced this issue Aug 12, 2024
The length modifier is required with a vector specifier.

Fixes KhronosGroup#2039

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
@svenvh
Copy link
Member

svenvh commented Aug 12, 2024

Alternatively (to a revert), I think this should fix the vector test too: #2044

@shajder
Copy link
Contributor

shajder commented Aug 27, 2024

Alternatively (to a revert), I think this should fix the vector test too: #2044

@svenvh is there anything more to do around this issue ?

@svenvh
Copy link
Member

svenvh commented Aug 27, 2024

If #2044 gets merged I believe we can close this issue.

svenvh added a commit that referenced this issue Aug 29, 2024
The length modifier is required with a vector specifier.

Fixes #2039

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants