Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printf: add missing vector length modifiers #2044

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

svenvh
Copy link
Member

@svenvh svenvh commented Aug 12, 2024

The length modifier is required with a vector specifier.

Fixes #2039

The length modifier is required with a vector specifier.

Fixes KhronosGroup#2039

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
Copy link

@coldav coldav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked it passes for us locally.

@coldav
Copy link

coldav commented Aug 29, 2024

Could we get this merged please?

@svenvh
Copy link
Member Author

svenvh commented Aug 29, 2024

Merging as this should be uncontroversial, and has 2 different vendor approvals already.

@svenvh svenvh merged commit c0db608 into KhronosGroup:main Aug 29, 2024
7 checks passed
@svenvh svenvh deleted the printf-vector-fixes branch August 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

printf is incorrectly testing vector arguments
3 participants