Queue profiling and Device timebase equality test #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwawiork
reviewed
Feb 10, 2021
ellnor01
force-pushed
the
profiling_timebase
branch
2 times, most recently
from
4f426d3
to
fffb7ef
Compare
|
Any more comments for this PR? |
ellnor01
force-pushed
the
profiling_timebase
branch
from
fffb7ef
to
71bd00a
Compare
lakshmih
previously approved these changes
Aug 27, 2024
bashbaug
requested changes
Sep 16, 2024
Comment on lines
96
to
97
| test_assert_error(deviceTimeAfterQueue < eventSubmit, | ||
| "Device timestamp was taken before kernel was submitted"); |
There was a problem hiding this comment.
I don't think this is a safe check. The OpenCL execution model says:
Submitted: The command is flushed from the command-queue and submitted for execution on the device. Once flushed from the command-queue, a command will execute after any prerequisites for execution are met.
I believe this means that the transition to the SUBMITTED state can happen anytime after the QUEUED state, even if the event dependencies defining the "prerequisites for execution" are not yet met.
There was a problem hiding this comment.
Agree, this is how I interpreted the quoted paragraph from the specification as well. Assert removed.
Adds test to confirm that the timestamp returned from clGetEventProfilingInfo for an event on a device and a device timestamp queried from the same device are in the same timebase. Fixes KhronosGroup#753 Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
For OpenCL 3.0 clGetDeviceAndHostTimer is an optional feature. Check whether it is supported in profiling/profiling_timebase Fixes KhronosGroup#753 Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
ahesham-arm
force-pushed
the
profiling_timebase
branch
from
71bd00a
to
15def81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test to confirm that the timestamp returned from
clGetEventProfilingInfo for an event on a device and a device
timestamp queried from the same device are in the same timebase.
Fixes #753
Signed-off-by: Ellen Norris-Thompson ellen.norris-thompson@arm.com