Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend test coverage for clClonekernel #1251

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Extend test coverage for clClonekernel #1251

wants to merge 7 commits into from

Commits on Jul 16, 2024

  1. Add test coverage for clCloneKernel with args 

    Use `clSetKernelArg` to set args after kernel is cloned. Enqueue and
read the buffer to validate.
The test uses `buf_write_kernel` kernel program with 2 arguments.

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>
    @jainvikas8 @ahesham-arm
    jainvikas8 authored and ahesham-arm committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3d58b8b View commit details
    Browse the repository at this point in the history

  2. Fix: Replace test_error with test_assert_error 

    In test_clone_kernel, if `clEnqueueReadBuffer` was a success then
the error code would be `CL_SUCCESS`, which will not print the error
message when buffer validation fails, therefore replace with
`test_assert_error` to print the error message.

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>
    @jainvikas8 @ahesham-arm
    jainvikas8 authored and ahesham-arm committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e422edc View commit details
    Browse the repository at this point in the history

  3. Add test coverage for clCloneKernel with Execinfo 

    Use `clSetKernelExecInfo` after kernel is cloned and read the buffer
to validate.

The test uses the `set_kernel_exec_info_kernel` kernel program
with 2 arguments.

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>
    @jainvikas8 @ahesham-arm
    jainvikas8 authored and ahesham-arm committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    771b05a View commit details
    Browse the repository at this point in the history

  4. Add test covergae for clCloneKernel with no args 

    Clone a kernel with no args and enqueue.
The test uses `test_kernel_empty` kernel program with no arguments.

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>
    @jainvikas8 @ahesham-arm
    jainvikas8 authored and ahesham-arm committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2bdcdf7 View commit details
    Browse the repository at this point in the history

  5. Add test coverge for clCloneKernel with SVM pointer 

    Use `clSetKernelArgSVMPointer` to set args after kernel is cloned.
Enqueue and read the buffer to validate.
The test uses `buf_write_kernel` kernel program with 2 arguments.

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>
    @jainvikas8 @ahesham-arm
    jainvikas8 authored and ahesham-arm committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    791ed1b View commit details
    Browse the repository at this point in the history

  6. fixup! Add test coverage for clCloneKernel with Execinfo 

    Review comments
    @jainvikas8 @ahesham-arm
    jainvikas8 authored and ahesham-arm committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0c2fb2c View commit details
    Browse the repository at this point in the history

  7. fixup! Add test coverge for clCloneKernel with SVM pointer 

    Review comments
    @jainvikas8 @ahesham-arm
    jainvikas8 authored and ahesham-arm committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    938be73 View commit details
    Browse the repository at this point in the history