Extend clSetDefaultDeviceCommandQueue test coverage
#1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeremy-Kemp
reviewed
Jun 17, 2021
| CL_QUEUE_PROPERTIES, (PROPERTIES | CL_QUEUE_ON_DEVICE_DEFAULT), 0 | ||
| }; | ||
|
|
||
| if (get_device_cl_version(deviceID) <= Version(3, 0)) |
There was a problem hiding this comment.
I think this should be >= as CL_DEVICE_DEVICE_ENQUEUE_CAPABILITIES does not exist prior to 3.0.
There was a problem hiding this comment.
Idea is to skip if it doesn't exists
There was a problem hiding this comment.
Right, but at the moment this test will be run on a 2.1 implementation so calling clGetDeviceInfo with CL_DEVICE_DEVICE_ENQUEUE_CAPABILITIES will (should) return CL_INVALID_VALUE.
Jeremy-Kemp
reviewed
Jun 17, 2021
|
Not sure, why code format check is failing, as they are none are changes related to this PR |
jainvikas8
force-pushed
the
extend-clSetQueue
branch
from
4b4bbb4
to
898ff6a
Compare
jainvikas8
changed the title
clSetDefaultDeviceCommandQueue test coverageclSetDefaultDeviceCommandQueue test coverage
jainvikas8
changed the title
clSetDefaultDeviceCommandQueue test coverageclSetDefaultDeviceCommandQueue test coverage
|
This change is ready for review. |
Fixes KhronosGroup#23 Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>
ahesham-arm
force-pushed
the
extend-clSetQueue
branch
from
898ff6a
to
e93c70a
Compare
|
@kpet Rebased and CI checks are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Add some positive testing for
clSetDefaultDeviceCommandQueue