Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math bruteforce test - enable erf/erfc functions #1289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gwawiork
Copy link
Contributor

It was disabled because lack of reference implementation. However the reference implementation exists. Then no reason to start testing these functions.

@bashbaug
Copy link
Contributor

bashbaug commented Jul 9, 2024

@gwawiork heads up, this could use a rebase to fix the merge conflict.

lakshmih
lakshmih previously approved these changes Jul 29, 2024
Copy link
Contributor

@lakshmih lakshmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase but looks good.

@gwawiork gwawiork force-pushed the tmp_bruteforce_fixed_erf branch 3 times, most recently from 676779d to 16bb00a Compare August 20, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants