Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate test_basic image_array_copy #1538

Merged

Conversation

JohnKesapidesARM
Copy link
Contributor

Merge image_array_copy, image_array_copy3d
as they share a lot of common code.

Signed-off-by: John Kesapides john.kesapides@arm.com

EwanC
EwanC previously approved these changes Oct 18, 2022
@kpet
Copy link
Contributor

kpet commented Jul 2, 2024

2024/07/02 teleconference: @JohnKesapidesARM This needs rebasing.

Merge image_array_copy, image_array_copy3d
as they share a lot of common code.

Signed-off-by: John Kesapides <john.kesapides@arm.com>
@ahesham-arm
Copy link
Contributor

2024/07/02 teleconference: @JohnKesapidesARM This needs rebasing.

@kpet Rebased and all CI checks passing.

Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Trusting the 2022 review I did here and looking at the test_imagearraycopy.cpp diff from the rebase (which is small)

@bashbaug
Copy link
Contributor

bashbaug commented Jul 9, 2024

Merging as discussed in the July 9th teleconference.

@bashbaug bashbaug merged commit cb9b8db into KhronosGroup:main Jul 9, 2024
7 checks passed
@ahesham-arm ahesham-arm deleted the deduplicate_image_array_copy branch July 9, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants