-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cl_half support for test_select #1617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried this PR on Codeplay's implementation and can see the new tests pass (and skip correctly against an implementation without cl_khr_fp16), but need to review the PR in more detail.
To follow up, I've looked through this again, and happy that how it adds half support is consistent with the other tests. How/when to do the refactoring to make it nicer is another question. |
…laced C object with wrappers
@EwanC due to the fact my project comes to an end and I can't see any progress around PR I am blocked with I decided to move on. Except of corrections for above requests I've added optimization which seems to speed up the test ~18% at my machine. Moreover, I've replaced CL objects with specific wrappers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EwanC due to the fact my project comes to an end and I can't see any progress around #1665 I am blocked with I decided to move on.
Except of corrections for above requests I've added optimization which seems to speed up the test ~18% at my machine. Moreover, I've replaced CL objects with specific wrappers.
Had a look through this again, and happy with where we've got to with this change.
LGTM, but please remove the excess semicolon that Ewan pointed out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, aside from one minor comment.
I didn't do a super detailed code review but I did verify that the additions pass on our implementation and I did not see any change in coverage (aside from the added half tests). Thanks!
Close/open to trigger CI |
According to issue description (select section):
#142