Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cl_khr_fp16 extension support for test_commonfns #1695

Merged
merged 15 commits into from
Jun 27, 2023
Merged

Added cl_khr_fp16 extension support for test_commonfns #1695

merged 15 commits into from
Jun 27, 2023

Conversation

shajder
Copy link
Contributor

@shajder shajder commented Apr 4, 2023 •
edited
Loading

This PR is direct extension of modernization PR #1694 . To avoid conflicts I would suggest to merge modernization PR first. Additional remarks:
-in degrees/radians test cases I had to add condition to verify if result and reference are both infinite
-I've changed ranges of half generation to stick to reasonable values - that could be possible candidate for corrections

EwanC
EwanC reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to look at this in more detail, but left some cursory comments. I also tried this branch out against Codeplay's half implementation and it passed.

test_conformance/commonfns/test_unary_fn.cpp Outdated Show resolved Hide resolved
test_conformance/commonfns/test_unary_fn.cpp Outdated Show resolved Hide resolved
test_conformance/commonfns/test_unary_fn.cpp Outdated Show resolved Hide resolved
test_conformance/commonfns/test_base.h Outdated Show resolved Hide resolved
test_conformance/commonfns/test_base.h Outdated Show resolved Hide resolved
test_conformance/commonfns/main.cpp Outdated Show resolved Hide resolved
@shajder shajder marked this pull request as ready for review May 23, 2023 13:30
shajder added a commit to shajder/OpenCL-CTS that referenced this pull request Jun 12, 2023
@shajder
Moved string helpers procedures due to request from test_commonfns PR K…
5b3d1a5 
…hronosGroup#1695
shajder added a commit to shajder/OpenCL-CTS that referenced this pull request Jun 12, 2023
@shajder
Moved string helper procedures due to request from test_commonfns PR K…
310d2ed 
…hronosGroup#1695
shajder added a commit to shajder/OpenCL-CTS that referenced this pull request Jun 12, 2023
@shajder
Moved string helper procedures due to request for test_commonfns PR K…
16719f1 
…hronosGroup#1695
EwanC
EwanC reviewed Jun 13, 2023
View reviewed changes
test_conformance/commonfns/test_mix.cpp Outdated Show resolved Hide resolved
test_conformance/commonfns/test_mix.cpp Show resolved Hide resolved
test_conformance/commonfns/test_smoothstep.cpp Show resolved Hide resolved
test_conformance/commonfns/test_unary_fn.cpp Outdated Show resolved Hide resolved
EwanC
EwanC previously approved these changes Jun 14, 2023
View reviewed changes
svenvh
svenvh requested changes Jun 20, 2023
View reviewed changes
test_conformance/commonfns/test_clamp.cpp Outdated Show resolved Hide resolved
test_conformance/commonfns/test_binary_fn.cpp Outdated Show resolved Hide resolved
test_conformance/commonfns/test_mix.cpp Show resolved Hide resolved
test_conformance/commonfns/test_step.cpp Outdated Show resolved Hide resolved
svenvh
svenvh previously approved these changes Jun 20, 2023
View reviewed changes
bashbaug pushed a commit that referenced this pull request Jun 20, 2023
@shajder
Added cl_khr_fp16 extension support for test_fpmath from basic (#1718)
0e229b8 
* Added half and double support for fpmath test from basic (issue #142, basic)

* Cosmetic corrections due to code review

* Removed unnecessary casting

* Added corrections due to code review

* Tuning range of input generation to avoid hitting infinity

* Moved string helpers procedures due to request from test_commonfns PR #1695
bashbaug pushed a commit that referenced this pull request Jun 20, 2023
@shajder
Added cl_khr_fp16 extension support for test_int2fp from basic (#1742)
df3ec8d 
* Added cl_khr_fp16 and cl_khr_fp64 support for float2int and int2float tests from basic

* removed debug output

* Replaced procedure to generate random half values in specific range (issue #142, basic)

* Added cosmetic fixes due to code review comments

* Moved string helper procedures due to request for test_commonfns PR #1695
lakshmih
lakshmih previously approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@lakshmih lakshmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the merge conflict.

@shajder shajder dismissed stale reviews from lakshmih and svenvh via 36f4805 June 21, 2023 09:28
@neiltrevett neiltrevett merged commit 2495eca into KhronosGroup:main Jun 27, 2023
6 checks passed
neiltrevett pushed a commit that referenced this pull request Jul 11, 2023
@shajder
Added cl_khr_fp16 extension support for test_vloadstore from basic (#…
3a1388a 
…1734)

* Added cl_khr_fp16 support for test_vloadstore from basic (issue #142, basic)

* Moved string helper procedures due to request from test_commonfns PR #1695

* restored original test sizes

* Corrected invalid initialization of reference buffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakshmih lakshmih lakshmih approved these changes

@svenvh svenvh svenvh approved these changes

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shajder @lakshmih @svenvh @EwanC @bashbaug @neiltrevett