Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cl_khr_fp16 extension support for test_explicit_s2v from basic #1713

Merged
merged 13 commits into from
Oct 17, 2023
Merged

Added cl_khr_fp16 extension support for test_explicit_s2v from basic #1713

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c8bd3c8
Added cl_khr_fp16 support for test_explicit_s2v from basic (issue #14…
shajder Apr 27, 2023
6f4afbe
Cosmetic corrections
shajder Apr 27, 2023
dc2c492
cosmetic fix
shajder Apr 27, 2023
52c8047
Added correction to distinguish signed and unsigned char types for AR…
shajder May 11, 2023
b067494
Added missing pieces of convertion procedure to support half
shajder Jun 14, 2023
94fa1ef
Merge branch 'main' into fp16_basic_explicit_s2v
shajder Jul 6, 2023
242c767
Corrected condition to verify if additional pragma is necessary (issu…
shajder Jul 6, 2023
ffb7738
Add NaN check for half to float conversion
Aug 1, 2023
c7055fd
check-format fixes
lakshmih Sep 5, 2023
7d78bcd
Add NaN check for all float types
Oct 4, 2023
cc6389b
Fix Ubuntu build error with isnan macro definition
Oct 10, 2023
9ad151a
Check format fixes
lakshmih Oct 12, 2023
a541f4b
NAN define not needed anymore
lakshmih Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions test_conformance/basic/test_explicit_s2v.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.
//
#include <cmath>
#define isnan std::isnan
bashbaug marked this conversation as resolved.
Show resolved Hide resolved
#include "harness/compat.h"

#include <stdio.h>
Expand Down Expand Up @@ -98,16 +100,6 @@ const char * kernel_explicit_s2v_set[NUM_VEC_TYPES][NUM_VEC_TYPES][5] = {

// clang-format on

int IsFloatNaN(double x)
{
union {
cl_float d;
cl_uint u;
} u;
u.d = (cl_float)x;
return ((u.u & 0x7fffffffU) > 0x7F800000U);
}

bool IsHalfNaN(cl_half v)
{
// Extract FP16 exponent and mantissa
Expand Down Expand Up @@ -179,10 +171,14 @@ int test_explicit_s2v_function(cl_context context, cl_command_queue queue,
{
if( memcmp( convertedData, outPtr + destTypeSize * s, destTypeSize ) != 0 )
{
if ((srcType == kHalf) && (destType == kFloat)
&& IsHalfNaN(*reinterpret_cast<cl_half *>(inPtr))
&& IsFloatNaN(*reinterpret_cast<cl_float *>(
outPtr + destTypeSize * s)))
bool isSrcNaN = (((srcType == kHalf) && IsHalfNaN(*reinterpret_cast<cl_half *>(inPtr)))
|| ((srcType == kFloat) && isnan(*reinterpret_cast<cl_float *>(inPtr)))
|| ((srcType == kDouble) && isnan(*reinterpret_cast<cl_double *>(inPtr))));
bool isDestNaN = (((destType == kHalf) && IsHalfNaN(*reinterpret_cast<cl_half *>(outPtr + destTypeSize * s)))
|| ((destType == kFloat) && isnan(*reinterpret_cast<cl_float *>(outPtr + destTypeSize * s)))
|| ((destType == kDouble) && isnan(*reinterpret_cast<cl_double *>(outPtr + destTypeSize * s))));

if (isSrcNaN && isDestNaN)
{
continue;
}
Expand Down
Loading