Add out of order tests for cl_khr_command_buffer_mutable_dispatch. #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>
EwanC
reviewed
May 29, 2023
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Outdated
Show resolved
Hide resolved
… command-buffer mutable buffer update. CL_KERNEL_EXEC_INFO_SVM_PTRS limits the test to devices which support SVM. Updating arg_list with a cl_mutable_dispatch_arg_khr struct is one of the best supported, and also easiest to verify, configurations to change. Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>
Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>
EwanC
reviewed
Jun 27, 2023
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Outdated
Show resolved
Hide resolved
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Outdated
Show resolved
Hide resolved
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Outdated
Show resolved
Hide resolved
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Outdated
Show resolved
Hide resolved
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Show resolved
Hide resolved
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Show resolved
Hide resolved
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Outdated
Show resolved
Hide resolved
Changes made: - Fix skip condition - Add event - Add memory verification Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>
EwanC
reviewed
Jun 29, 2023
...ensions/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_basic.h
Outdated
Show resolved
Hide resolved
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Outdated
Show resolved
Hide resolved
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Outdated
Show resolved
Hide resolved
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Outdated
Show resolved
Hide resolved
...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_out_of_order.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>
EwanC
previously approved these changes
Jul 3, 2023
21 tasks
EwanC
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.