Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dispatch arguments tests for cl_khr_command_buffer_mutable_dispatch. #1748

Closed

Conversation

pj87
Copy link
Contributor

@pj87 pj87 commented May 29, 2023

No description provided.

pj87 added 3 commits May 29, 2023 11:22
Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>
Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>
Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>
@EwanC
Copy link
Contributor

EwanC commented May 31, 2023

It's not clear to me what the intention of this test is compared to PR #1749 which is more comprehensive argument testing

@pj87
Copy link
Contributor Author

pj87 commented Jun 1, 2023

It's not clear to me what the intention of this test is compared to PR #1749 which is more comprehensive argument testing

The intention here was to query for CL_MUTABLE_DISPATCH_ARGUMENTS_KHR but from what I understand, there is no such query. Please confirm that this is the case so I will close this issue.

@EwanC
Copy link
Contributor

EwanC commented Jun 8, 2023

It's not clear to me what the intention of this test is compared to PR #1749 which is more comprehensive argument testing

The intention here was to query for CL_MUTABLE_DISPATCH_ARGUMENTS_KHR but from what I understand, there is no such query. Please confirm that this is the case so I will close this issue.

CL_MUTABLE_DISPATCH_ARGUMENTS_KHR is a bitfield bit that can be set as part of the cl_mutable_dispatch_fields_khr type. It can be either be returned by the query for device capabilites, or set as a bit on the properties to clCommandNDRangeKernelKHR. However, this would all naturally be covered in #1749 as a necessary part of argument testing, so indeed we don't this separate PR and it can be closed.

@pj87 pj87 closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants