Command buffer wait_for_sec_queue_event subtest, call clFinish in the correct order.

[AhmedAmraniAkdi]

queue has a command that depends on a command that resides in queue_sec, calling clFinish(queue) before clFinish(queue_sec) causes the test to hang as the queue_sec command never got a chance to finish.

[AhmedAmraniAkdi]

It says build macos-latest failed, but I am unsure the reason is my change.

[svenvh]

It says build macos-latest failed, but I am unsure the reason is my change.

That should be fixed by #1756

[EwanC]

LGTM

[bashbaug]

This change isn't bad but I do wonder if it is defeating the purpose of the test. Would it be better to at least call clFlush(queue) first, before calling clFinish(queue_sec)? So we'd have:

        error = clFlush(queue);
        test_error(error, "clFlush failed");

        error = clFinish(queue_sec);
        test_error(error, "clFinish failed");

        error = clFinish(queue);
        test_error(error, "clFinish failed");

[AhmedAmraniAkdi]

Yes, that works too as clFlush is not blocking and it also goes more "in line" with what the test was doing. Should I modify the commit with your suggestion then?

[lakshmih]

Looks good.

[EwanC]

Yes, that works too as clFlush is not blocking and it also goes more "in line" with what the test was doing. Should I modify the commit with your suggestion then?

I'd also prefer the patch was updated to this suggestion

[AhmedAmraniAkdi]

Updated PR.

[bashbaug]

This change works for me - thanks!

Do we need any further discussion or spec clarifications to document whether or why the previous code was incorrect?

[bashbaug]

Merging as discussed in the September 5th teleconference.