conversions: fix undefined behaviour in DataInfoSpec #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For conversion from integers to float, the DataInfoSpec constructor tries to convert `CL_FLT_MAX` to an integer. The float value cannot be represented as an integer, which is undefined behaviour. Fix by only doing this conversion when `InType` is a floating point value. While at it, use `static_cast` for the conversions. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
The refactoring of the conversions test dropped the workaround added by 59a1204 ("Fix for test_conversions failure with Clang build on Linux KhronosGroup#1057 (KhronosGroup#1062)", 2021-05-11). Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
alan-baker
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For conversion from integers to floating point, the
DataInfoSpecconstructor tries to convertCL_FLT_MAXto an integer. The float value cannot be represented as an integer, which is undefined behaviour.Fix by only doing this conversion when
InTypeis a floating point value.The refactoring of the conversions test dropped the workaround added by 59a1204 ("Fix for test_conversions failure with Clang build on Linux #1057 (#1062)", 2021-05-11).
While at it, prefer
static_castfor the conversions.