Add ffp-contract=off Compilation flag for CTS build. #1803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, enqueue_flags test uses CLK_LOCAL_MEM_FENCE. Use CLK_GLOBAL_MEM_FENCE instead as all threads across work-groups need to wait here.
Update nikhilj-nv/OpenCL-CTS:master with KhronosGroup/OpenCL-CTS:master
Read-Write images have required OpenCL 2.x. Read-Write image tests are already being skipped for 1.x devices. With OpenCL 3.0, read-write images being optional, the tests should be run or skipped depending on the implementation support. Add a check to decide if Read-Write images are supported or required to be supported depending on OpenCL version and decide if the tests should be run on skipped. Fixes issue KhronosGroup#894
Fix formatting in case of Read-write image checks. Also, combine two ifs into one in case of kerne_read_write tests
Remove unnecessary spaces at various places. Also, fix lengthy lines.
Update nikhiljnv/OpenCL-CTS:master with KhronosGroup/OpenCL-CTS:master
Merge Khronos:OpenCL-CTS:master into nikhilj:OpenCL-CTS:master
unsigned char size is silently assumed to be 1 in imagedim test of test_basic. Pass sizeof(type) in malloc size calculation. Also, change loop variable from signed to unsigned. Add checks for null pointer for malloced memory.
…nto KhronosGroup-master
Merge latest KhronosGroup/OpenCL-CTS:master into nikhilnv/OpenCL-CTS:KhronosGroup-master
Initial set of tests for below extensions with Vulkan as producer 1. cl_khr_external_memory 2. cl_khr_external_memory_win32 3. cl_khr_external_memory_opaque_fd 4. cl_khr_external_semaphore 5. cl_khr_external_semaphore_win32 6. cl_khr_external_semaphore_opaque_fd
Updates to external sharing CTS 1. Fix some build issues to remove unnecessary, non-existent files 2. Add new tests for platform and device queries. 3. Some added checks for VK Support.
Update CTS build to clone Vulkan Headers repo and pass it to CTS build in preparation for external memory and semaphore tests
Update CTS build script for Vulkan Headers
Fix Vulkan header include path.
Fix Vulkan header path
Vulkan loader is required to build test_vulkan of OpenCL-CTS. Clone and build Vulkan loader as prerequisite to OpenCL-CTS.
Remove arch/os suffix in Vulkan loader path to match vulkan loader repo build.
Updates to external sharing CTS
Return type of getHandle is defined differently based on win or linux builds. Use appropriate guards when using API at other places. While at it remove duplicate definition of ARRAY_SIZE.
Use already defined ARRAY_SIZE macro from test_harness.
Fix build issues for test_vulkan 1. Add cl_ext.h in common files 2. Replace cl_mem_properties_khr with cl_mem_properties 3. Replace cl_external_mem_handle_type_khr with cl_external_memory_handle_type_khr 4. Type-cast malloc as required.
Fix warnings around getHandle API and macros
Fix code formatting to get CTS CI builds clean.
Another set of formatting fixes.
Some more code formatting fixes.
More code formatting fixes.
Some more formatting fixes
More formatting fixes continued.
Code formatting fixes for image
Misc fixes for external sharing tests
Use appropriate headers for Mac OSX builds
Fix headers for Mac OSX builds.
Use appropriate headers for Mac OSX builds. Also, fix some build issues due to type-casting.
Fix remaining build issue for MacOS
Fix new code formatting issues with recent MacOS fixes.
Fix new code formatting issues
Add back missing case statement that was accidentally removed.
Add back missing case statement
Disable USE_GAS for Vulkan Loader build to fix aarch64 build.
Disable USE_GAS for Vulkan Loader build.
Fix clReleaseSemaphore() API. Fix copyright year. Some other minor fixes.
Use SPIR-V shaders instead of NV extension path from GLSL to Vulkan shaders. Fixes for lower end GPUs to use limited memory. Update copy-right year at some more places.
Fix code formatting issues with recent changes for external sharing tests.
Fix new code formatting issues.
More formatting fixes for recent updates to external sharing tests.
More formatting fixes.
Minor formatting fixes to get format checks clean.
Final code formatting fixes.
Merge KhronosGroup/OpenCL-CTS:main to nikhiljnv/OpenCL-CTS:main
External sharing new updates
Upate extension list of test_compiler with missing external memory and semaphore extensions
Update nikhiljnv/OpenCL-CTS with latest KhronosGroup/OpenCL-CTS changes
test_vulkan is disabled by default as part of PR KhronosGroup#1530. Given the ongoing development to test_vulkan, it is important to have this enabled in CI builds to avoid breaking test builds. Enable the test build as part of presubmit script.
GCC defaults to using ffp-contract=fast even when fast math is disabled in the case of GNU C This creates precision issues when comparing the results with that of x86_64. GNU options reference: https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html# This fix is to disable floating-point expression contractions with flag ffp-contract=off for math_brute_force tests Fixes KhronosGroup#1794
|
Closing in favor of #1805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC defaults to using ffp-contract=fast even when fast math is disabled in the
case of GNU C
This creates precision issues when comparing the results with that of x86_64.
GNU options reference:
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html#
This fix is to disable floating-point expression contractions with
flag ffp-contract=off for math_brute_force tests
Fixes #1794