Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test IMAGE1D_BUFFER in more scenario #1806

Merged
merged 21 commits into from
Apr 16, 2024
Merged

Test IMAGE1D_BUFFER in more scenario #1806

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
cfdc23a
cl_copy_images
rjodinchr Aug 10, 2023
f6bcdb1
cl_get_info
rjodinchr Aug 10, 2023
1992631
cl_fill_image
rjodinchr Aug 10, 2023
0554854
cl_read_write_image
rjodinchr Aug 10, 2023
eb452c1
kernel_image_methods
rjodinchr Aug 10, 2023
1db645f
IMAGE1D_BUFFER cannot be created with (USE_|ALLOC_|COPY_)_HOST_PTR
rjodinchr Oct 16, 2023
598bb72
do not allow mipmap with 1D buffer
rjodinchr Nov 10, 2023
d471d47
adjust M to be within maximum_sizes and max_pixels
rjodinchr Nov 10, 2023
7e51654
remove unused variables
rjodinchr Nov 10, 2023
4ca814c
make sure M will never be 0
rjodinchr Jan 7, 2024
16e3343
fix region[0] after refactoring removing mipmap
rjodinchr Jan 7, 2024
5c62489
fix formatting
rjodinchr Feb 13, 2024
b3cca5c
format with clang-format-11
rjodinchr Feb 13, 2024
9c6c166
fix image1d_buffer creation with gEnablePitch
rjodinchr Feb 27, 2024
f101b60
add missing case in switch
rjodinchr Feb 28, 2024
8d5fee9
use align_malloc when CL version is at least 2.0
rjodinchr Mar 5, 2024
84e5fc2
use CL_DEVICE_NUMERIC_VERSION and align_free
rjodinchr Mar 12, 2024
9a49a34
fix free of pitch buffer
rjodinchr Mar 27, 2024
cd53e28
fix formatting
rjodinchr Mar 27, 2024
26255dd
fix formatting
rjodinchr Mar 27, 2024
71eca12
fix data->is_aligned
rjodinchr Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions test_conformance/images/clFillImage/test_fill_generic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,16 @@ cl_mem create_image( cl_context context, cl_command_queue queue, BufferOwningPtr
if (gDebugTrace)
log_info(" - Creating 1D buffer image %d ...\n",
(int)imageInfo->width);
if (gEnablePitch) host_ptr = malloc(imageInfo->rowPitch);
{
cl_int err;
cl_mem buffer =
clCreateBuffer(context, CL_MEM_READ_WRITE,
imageInfo->rowPitch, host_ptr, &err);
cl_mem_flags buffer_flags = CL_MEM_READ_WRITE;
if (gEnablePitch)
{
host_ptr = malloc(imageInfo->rowPitch);
rjodinchr marked this conversation as resolved.
Show resolved Hide resolved
buffer_flags |= CL_MEM_USE_HOST_PTR;
}
cl_mem buffer = clCreateBuffer(
context, buffer_flags, imageInfo->rowPitch, host_ptr, &err);
if (err != CL_SUCCESS)
{
log_error("ERROR: Could not create buffer for 1D buffer "
Expand All @@ -103,10 +107,22 @@ cl_mem create_image( cl_context context, cl_command_queue queue, BufferOwningPtr
log_error( "ERROR: Unable to create backing store for pitched 3D image. %ld bytes\n", imageInfo->depth * imageInfo->slicePitch );
return NULL;
}
mem_flags = CL_MEM_READ_ONLY | CL_MEM_USE_HOST_PTR;
if (imageInfo->type != CL_MEM_OBJECT_IMAGE1D_BUFFER)
{
mem_flags = CL_MEM_READ_ONLY | CL_MEM_USE_HOST_PTR;
}
}

img = clCreateImage(context, mem_flags, imageInfo->format, &imageDesc, host_ptr, error);
if (imageInfo->type != CL_MEM_OBJECT_IMAGE1D_BUFFER)
{
img = clCreateImage(context, mem_flags, imageInfo->format, &imageDesc,
host_ptr, error);
}
else
{
img = clCreateImage(context, mem_flags, imageInfo->format, &imageDesc,
nullptr, error);
}

if (gEnablePitch)
{
Expand Down
Loading