-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test_compile.cpp #1812
Update test_compile.cpp #1812
Conversation
Prevent the error: "variable 'temp' is uninitialized when used here" Since one of the generated kernels starts with: __kernel void sample_test(__global float *src, __global int *dst) { float temp; int tid = get_global_id(0); dst[tid] = dst[tid] + temp;
clang format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'm guessing the first commit has the only real change and the second is just formatting updates?
Yes, it is. |
Change the "0.0" literal to "0.0f" for devices that don't support FP64.
Waiting one more week for additional review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, not sure we need to put the kernel code snippet in the commit message.
Thank you, Lakshmi. @bashbaug, can you please merge this? |
Merging as discussed in the October 10th teleconference. |
Prevent the error:
"variable 'temp' is uninitialized when used here"
Since one of the generated kernels starts with:
__kernel void sample_test(__global float *src, __global int *dst) {
float temp;
int tid = get_global_id(0);
dst[tid] = dst[tid] + temp;