Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_compile.cpp #1812

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Update test_compile.cpp #1812

merged 3 commits into from
Oct 10, 2023

Conversation

aharon-abramson
Copy link
Contributor

Prevent the error:
"variable 'temp' is uninitialized when used here"

Since one of the generated kernels starts with:

__kernel void sample_test(__global float *src, __global int *dst) {
float temp;
int tid = get_global_id(0);
dst[tid] = dst[tid] + temp;

Prevent the error:
"variable 'temp' is uninitialized when used here"

Since one of the generated kernels starts with:

__kernel void sample_test(__global float *src, __global int *dst)
{
    float temp;
    int  tid = get_global_id(0);
    dst[tid] = dst[tid] + temp;
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023

CLA assistant check
All committers have signed the CLA.

bashbaug
bashbaug previously approved these changes Sep 26, 2023
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm guessing the first commit has the only real change and the second is just formatting updates?

@aharon-abramson
Copy link
Contributor Author

LGTM - I'm guessing the first commit has the only real change and the second is just formatting updates?

Yes, it is.

Change the "0.0" literal to "0.0f" for devices that don't support FP64.
@bashbaug
Copy link
Contributor

bashbaug commented Oct 3, 2023

Waiting one more week for additional review.

Copy link
Contributor

@lakshmih lakshmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, not sure we need to put the kernel code snippet in the commit message.

@aharon-abramson
Copy link
Contributor Author

Thank you, Lakshmi. @bashbaug, can you please merge this?

@bashbaug
Copy link
Contributor

Merging as discussed in the October 10th teleconference.

@bashbaug bashbaug merged commit 60fc7fc into KhronosGroup:main Oct 10, 2023
6 checks passed
@aharon-abramson aharon-abramson deleted the patch-1 branch October 8, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants