Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes in mutable dispatch tests. #1829

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Minor fixes in mutable dispatch tests. #1829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
655e757
Minor fixes in mutable dispatch tests.
JohnKesapidesARM Sep 27, 2023
16d631c
* Set the row_pitch for imageInfo in MutableDispatchImage1DArguments
JohnKesapidesARM Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...l_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,8 +664,8 @@ struct MutableDispatchSVMArguments : public BasicMutableCommandBufferTest

// Allocate and initialize SVM for modified execution

cl_int *newWrapper =
(cl_int *)clSVMAlloc(context, CL_MEM_READ_WRITE, sizeof(cl_int), 0);
cl_int *newWrapper = (cl_int *)clSVMAlloc(context, CL_MEM_READ_WRITE,
sizeof(cl_int *), 0);
cl_int *newBuffer = (cl_int *)clSVMAlloc(
context, CL_MEM_READ_WRITE, num_elements * sizeof(cl_int), 0);
test_assert_error(newWrapper != nullptr && newBuffer != nullptr,
Expand Down
2 changes: 2 additions & 0 deletions ...command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_image_arguments.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ struct MutableDispatchImage1DArguments : public BasicMutableCommandBufferTest
imageInfo.type = CL_MEM_OBJECT_IMAGE1D;
imageInfo.format = &formats;
imageInfo.width = 4;
imageInfo.rowPitch = imageInfo.width * get_pixel_size(imageInfo.format);

BufferOwningPtr<char> imageValues_input, imageValues_output, outputData;
MTdataHolder d(gRandomSeed);
Expand Down Expand Up @@ -285,6 +286,7 @@ struct MutableDispatchImage2DArguments : public BasicMutableCommandBufferTest
imageInfo.width = 4;
imageInfo.height = 4;
imageInfo.format = &formats;
imageInfo.rowPitch = imageInfo.width * get_pixel_size(imageInfo.format);

BufferOwningPtr<char> imageValues_input, imageValues_output;

Expand Down
3 changes: 2 additions & 1 deletion ...ons/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_info.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ struct Dimensions : public InfoMutableCommandBufferTest
{
cl_int error = clCommandNDRangeKernelKHR(
command_buffer, nullptr, nullptr, kernel, dimensions, nullptr,
&global_work_size, nullptr, 0, nullptr, nullptr, &command);
global_work_size_3d, nullptr, 0, nullptr, nullptr, &command);
test_error(error, "clCommandNDRangeKernelKHR failed");

cl_uint test_dimensions = 0;
Expand All @@ -231,6 +231,7 @@ struct Dimensions : public InfoMutableCommandBufferTest

cl_mutable_command_khr command = nullptr;
const size_t dimensions = 3;
const size_t global_work_size_3d[3] = { 64, 1, 1 };
};

struct InfoType : public InfoMutableCommandBufferTest
Expand Down
Loading