Raw10/12 CTS tests #1830
Merged
Raw10/12 CTS tests #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeremy-Kemp
reviewed
Nov 29, 2023
test_common/harness/imageHelpers.h
Outdated
| switch (format->image_channel_data_type) | ||
| { | ||
| case CL_UNSIGNED_INT_RAW10_EXT: { | ||
| ptr += z * slice_pitch_lod + y * row_pitch_lod + (x / 4) * 5; |
There was a problem hiding this comment.
Can we use RAW10_EXT_CLUMP_SIZE and RAW10_EXT_CLUMP_NUM_PIXELS throughout instead? (Same for raw12)
There was a problem hiding this comment.
sure, I'll make the change
| @@ -385,6 +393,7 @@ test_definition test_list[] = { | |||
| ADD_TEST_VERSION(image_from_small_buffer_negative, Version(3, 0)), | |||
| ADD_TEST_VERSION(image_from_buffer_fill_positive, Version(3, 0)), | |||
| ADD_TEST_VERSION(image_from_buffer_read_positive, Version(3, 0)), | |||
| ADD_TEST_VERSION(cl_ext_image_raw10_raw12, Version(3, 0)), | |||
There was a problem hiding this comment.
This extension could be supported from a 1.2 implementation.
Add support for cl_ext_image_raw10_raw12 testing on test_image_streams. Signed-off-by: John Kesapides <john.kesapides@arm.com>
JohnKesapidesARM
force-pushed
the
raw10_12_tests
branch
from
2db755c
to
ade77d5
Compare
Jeremy-Kemp
approved these changes
May 14, 2024
lakshmih
approved these changes
May 20, 2024
|
Merging as discussed in the May 21st teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for cl_ext_image_raw10_raw12 testing
on test_image_streams.