Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the Vulkan interop buffer kernel workgroup size to 128 #1846

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Reduce the Vulkan interop buffer kernel workgroup size to 128 #1846

merged 1 commit into from
Nov 23, 2023

Conversation

kpet
Copy link
Contributor

@kpet kpet commented Nov 14, 2023

Vulkan guarantees 128 is always supported.

Relates to #1828

@nikhiljnv
Copy link
Contributor

As discussed on Memory subgroup call on November 21, 2023, waiting until CI is clean on this one.
Looks like the resubmitted jobs failed as well.

@nikhiljnv
Copy link
Contributor

This looks like due to mismatch in headers and CTS, although I see the latest CTS doesn't have CL_DEVICE_HANDLE_LIST_KHR.
Not sure if CI is picking up some older version of CTS before #1814
/home/runner/work/OpenCL-CTS/OpenCL-CTS/test_conformance/extensions/cl_khr_external_semaphore/test_external_semaphore.cpp:123:26: error: ‘CL_DEVICE_HANDLE_LIST_KHR’ was not declared in this scope; did you mean ‘CL_MEM_DEVICE_HANDLE_LIST_KHR’?
123 | SEMAPHORE_PARAM_TEST(CL_DEVICE_HANDLE_LIST_KHR, cl_device_id, deviceID);
| ^~~~~~~~~~~~~~~~~~~~~~~~~

@kpet
Reduce the Vulkan interop buffer kernel workgroup size to 128
8ecb227 
Vulkan guarantees 128 is always supported.

Relates to KhronosGroup#1828

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
@nikhiljnv
Copy link
Contributor

Merging as discussed in Memory subgroup call on November 21, 2023. CI is clean now and all checks have passed.

@nikhiljnv nikhiljnv merged commit 5815e2c into KhronosGroup:main Nov 23, 2023
7 checks passed
@dneto0 dneto0 mentioned this pull request Nov 28, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpet @nikhiljnv @bashbaug