Add NULL CL_MEM_HOST_PTR check for all flag combinations #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec requires implementations return NULL for CL_MEM_HOST_PTR when the flags passed at memory object creation time do not contain CL_MEM_USE_HOST_PTR CTS was not checking this. Add the same check. Fixes KhronosGroup#1752
As part of suggestions to KhronosGroup#1801, add NULL CL_MEM_HOST_PTR check for all flag combinations. Fixes KhronosGroup#1752
Fix formatting issues
bashbaug
reviewed
Feb 27, 2024
There was a problem hiding this comment.
The change itself looks good to me, though we should close on KhronosGroup/OpenCL-Docs#1008 before merging.
|
Verified on Intel CPU device. |
bashbaug
approved these changes
Mar 12, 2024
|
Merging as discussed in the March 12th teleconference. |
rjodinchr
added a commit
to rjodinchr/clvk
that referenced
this pull request
Mar 18, 2024
kpet
added a commit
to kpet/clvk
that referenced
this pull request
Mar 18, 2024
* fix clGetMemObjectInfo of CL_MEM_HOST_PTR after fix in CTS KhronosGroup/OpenCL-CTS#1850 * Update src/api.cpp Co-authored-by: Kévin Petit <kpet@free.fr> --------- Co-authored-by: Kévin Petit <kpet@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of suggestions to #1801, add NULL CL_MEM_HOST_PTR
check for all flag combinations.
Fixes #1752