apply environment variable CL_PLATFORM_INDEX to test_compute_info #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for selecting platform in compute_info test through environment variable setting.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variable CL_PLATFORM_INDEX was meant to be used to specify the platform on which the conformance test should be run, but the compute_info test does not properly utilize this particular environment variable, which might cause unexpected test failure in a multi-platform environment.
Previously in the test_compute_info function, the first clGetPlatformIDs call just passed constant value 1 as the first argument, which would only be able to get the ID of the first platform, regardless of the CL_PLATFORM_INDEX setting.
After the change, it would first be checked whether the CL_PLATFORM_INDEX is a valid platform index, and falls back to use the first platform if no environment variable is provided.
Similar function has already be implemented in the source file testHarness.cpp, but the current test_compute_info function lacks appropriate support for platform selection through the enviroment variable.