Fix cts build error on mariner OS

[jujiang-del]

No description provided.

[CLAassistant]

All committers have signed the CLA.

[bashbaug]

This change looks reasonable but I'm having trouble understanding why the previous code was not OK. Could you please provide more information about the build error? Thanks!

[jujiang-del]

This change looks reasonable but I'm having trouble understanding why the previous code was not OK. Could you please provide more information about the build error? Thanks!

The error was"/test_conformance/extensions/cl_khr_command_buffer/command_buffer_printf.cpp:429:37: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
429 | pattern[pattern_length] = '\0';"

[jujiang-del]

!verify

[bashbaug]

Thanks, that's helpful. I'm guessing you're building with some version of gcc? Seems like this is a known false positive.

@svenvh, you've been most active eliminating warnings and enabling warnings as errors. How would you like to resolve this?

It's interesting that almost the exact same pattern appears, here, but this doesn't seem to be causing a problem:

OpenCL-CTS/test_conformance/extensions/cl_khr_command_buffer/command_buffer_printf.cpp

Lines 338 to 342 in 27e47e9

	unsigned pattern_length =
	std::max(min_pattern_length, rand() % max_pattern_length);
	char pattern_character = 'a' + rand() % 26;
	std::vector<cl_char> pattern(pattern_length + 1, pattern_character);
	pattern[pattern_length] = '\0';

[svenvh]

I've seen various Wstringop-overflow false positives over time indeed, affecting only some gcc versions. If this patch fixes the particular instance I'm okay with merging this.

[svenvh]

Closing and reopening to retrigger the buildbots.