Import Vulkan resources via named NT handle #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhnv
force-pushed
the
named_vk_resource
branch
from
47d3da4
to
6456d44
Compare
saurabhnv
force-pushed
the
named_vk_resource
branch
2 times, most recently
from
98383f3
to
4e1af10
Compare
joshqti
reviewed
Oct 8, 2024
joshqti
reviewed
Oct 8, 2024
| @@ -550,7 +550,7 @@ clExternalMemory::clExternalMemory(const clExternalMemory &externalMemory) | |||
| clExternalMemory::clExternalMemory( | |||
| const VulkanDeviceMemory *deviceMemory, | |||
| VulkanExternalMemoryHandleType externalMemoryHandleType, uint64_t size, | |||
| cl_context context, cl_device_id deviceId) | |||
| cl_context context, cl_device_id deviceId, cl_bool useNameForImport) | |||
There was a problem hiding this comment.
Yeah, looks like when I was writing this there was no CL_*_HANDLE_OPAQUE_WIN32_NAME_KHR, but since it is there now, will remove the added param and add those enums in VulkanExternalMemoryHandleType and VulkanExternalSemaphoreHandleType to use those instead.
* Associate an optional name with the vk resource when handle type is NT * Use the name when available for importing the resource in OpenCL * Refactor ctor/dtor for WindowsSecurityAttributes class
Minor change to support importing a named resource either directly using the associated name or via NT handle.
saurabhnv
force-pushed
the
named_vk_resource
branch
from
4e1af10
to
b715dcc
Compare
* Remove the unnecessary usage of useNameForImport * Add new enum to VulkanExternalMemoryHandleType and VulkanExternalSemaphoreHandleType
saurabhnv
force-pushed
the
named_vk_resource
branch
from
b715dcc
to
442b9d3
Compare
30 tasks
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coverage to import Vulkan resources (memory and semaphore) in Windows via named NT handles.
If no name is given during resource creation, then use NT handles for import.
If a name is given, have an option to either use that name or get the NT handle and use that for import.
Resolves KhronosGroup/OpenCL-Docs#943