Import OpenCL exported semaphore in Vulkan #1898
Conversation
saurabhnv
force-pushed
the
importable_exportable_semaphore
branch
from
33b0b07
to
4ef6727
Compare
| throw std::runtime_error("Failed to import semaphore in Vulkan\n"); | ||
| } | ||
| } | ||
| #ifdef _WIN32 |
There was a problem hiding this comment.
Use a switch or an else-if branch to explicitly match the windows handle enum type. If possible eliminate the ifdef, I made an effort to reduce the reliance of ifdefs to select semaphore handle types, and instead query the the platform for supported extensions. If eliminating the ifdef entirely is not possible, can its scope be reduced? What is the behavior if not WIN32 but also not opaque fd?
There was a problem hiding this comment.
Sure, actually I wasn't aware of your efforts made in that direction, will try to remove the ifdef.
As for your second question (I guess you are referring to sync_fd?), it still gets re-imported during every signal/wait operation.
There was a problem hiding this comment.
Addressed in recent commit, couldn't eliminate it completely as it uses vkImportSemaphoreWin32HandleKHR, a windows specific def as per vulkan header.
There was a problem hiding this comment.
Thanks, looks good. I will test and update if anything fails on my end.
There was a problem hiding this comment.
This change is fine. Lets merge.
Except for SYNC_FD, current implementation doesn't import exported OpenCL semaphore in vulkan and ends up doing signal and wait on essentially two unrelated semaphores (one created in OpenCL and one in Vulkan). * For linux FD and windows KMT/NT handle types, import the exported OpenCL semaphore in Vulkan after its creation. * Add vkImportSemaphoreWin32HandleKHR in VK_FUNC_LIST
* If importable is asked then create one. * If exportable is asked then check support for that particular handleType, if supported then create one otherwise fallback to importable semaphore.
* Replace direct creation of Importable/Exportable semaphore with the macro. * Use Importable when testing buffer_multiImport_diffCtx
saurabhnv
force-pushed
the
importable_exportable_semaphore
branch
2 times, most recently
from
18536cd
to
57f90bb
Compare
saurabhnv
force-pushed
the
importable_exportable_semaphore
branch
from
57f90bb
to
fab800a
Compare
Except for SYNC_FD, current implementation doesn't import exported OpenCL semaphore in Vulkan and ends up doing signal and wait on essentially two unrelated semaphores (one created in OpenCL and one in Vulkan).
Since OpenCL exports the semaphore, import that in Vulkan to perform signal/wait on the same underlying payload.