Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added negative tests for function CreateCommandBufferKHR from cl_khr_command_buffer #1915

Conversation

kamil-goras-mobica
Copy link
Contributor

According to description #1668

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests generally look good and they found an issue in the command buffer emulation layer (already fixed), so that's pretty cool.

Did we discuss whether to implement these tests in a separate executable or as a part of the existing command buffer executable? All else being equal I'd prefer to minimize the number of test executables, and I don't think we've had separate executables for negative tests previously.

@EwanC
Copy link
Contributor

EwanC commented Mar 13, 2024

Did we discuss whether to implement these tests in a separate executable or as a part of the existing command buffer executable? All else being equal I'd prefer to minimize the number of test executables, and I don't think we've had separate executables for negative tests previously.

I don't think we have discussed it. I would probably also err on the side of less test executables as I feel like new ones could get missed when people are maintain scripts/csvs for testing, but that's a slight preference rather than a strong one. Prefixing the new tests with negative_ I think would suitably identify the negative tests in the existing cl_khr_command_buffer executable.

@kamil-goras-mobica kamil-goras-mobica force-pushed the negative_create_command_buffer_tests branch from ec4a5e7 to 73b5b25 Compare March 25, 2024 08:35
@kamil-goras-mobica kamil-goras-mobica force-pushed the negative_create_command_buffer_tests branch from 73b5b25 to 8772c7a Compare March 25, 2024 11:06
EwanC
EwanC previously approved these changes Mar 25, 2024
@bashbaug
Copy link
Contributor

Merging as discussed in the April 16th teleconference.

@bashbaug bashbaug merged commit 7fa567c into KhronosGroup:main Apr 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants