Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added negative tests for clRetainCommandBufferKHR, clReleaseCommandBu… #1928

Conversation

kamil-goras-mobica
Copy link
Contributor

Added negative tests for clRetainCommandBufferKHR, clReleaseCommandBufferKHR, clFinalizeCommandBufferKHR

According to description #1668

Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from suggested change

EwanC
EwanC previously approved these changes Apr 9, 2024
EwanC
EwanC previously approved these changes Apr 12, 2024
@bashbaug
Copy link
Contributor

Agreed to merge in the April 16th teleconference once the conflicts are resolved.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts are resolved, merging as discussed.

@bashbaug bashbaug merged commit 308fa6e into KhronosGroup:main Apr 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants