Added negative tests for clEnqueueCommandBufferKHR #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
reviewed
Apr 5, 2024
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_enqueue.cpp
Show resolved
Hide resolved
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_enqueue.cpp
Outdated
Show resolved
Hide resolved
EwanC
reviewed
Apr 5, 2024
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_enqueue.cpp
Show resolved
Hide resolved
EwanC
added a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Apr 9, 2024
We aren't returning the correct errors as specified by `clEnqueueCommandBufferKHR`. Issues we're found based on testing of CTS PR KhronosGroup/OpenCL-CTS#1931 that verifies these errors
EwanC
added a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Apr 9, 2024
We aren't returning the correct errors as specified by `clEnqueueCommandBufferKHR`. Issues we're found based on testing of CTS PR KhronosGroup/OpenCL-CTS#1931 that verifies these errors. UnitCL tests need updating too, which were checking for incorrect error codes.
EwanC
previously approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Nice addition, caught a few non-conformities in OCK implementation uxlfoundation/oneapi-construction-kit#429
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_enqueue.cpp
Show resolved
Hide resolved
EwanC
added a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Apr 9, 2024
We aren't returning the correct errors as specified by `clEnqueueCommandBufferKHR`. Issues we're found based on testing of CTS PR KhronosGroup/OpenCL-CTS#1931 that verifies these errors. UnitCL tests need updating too, which were checking for incorrect error codes.
EwanC
previously approved these changes
Apr 10, 2024
|
Agreed to merge in the April 16th teleconference once the conflicts are resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to description #1668