Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test allocations: restore small number of work items in case of reduction #1932

Merged
merged 2 commits into from
May 21, 2024

Conversation

gwawiork
Copy link
Contributor

No description provided.

@gwawiork
Copy link
Contributor Author

@kpet This is related to #1852
We use reduction argument on simulation then too high number of work items makes test very long and we see timeouts. Would be nice have previous value set. I agree there is a need to implement function which will calculate this number accordingly

@kpet
Copy link
Contributor

kpet commented Mar 27, 2024

Merging this PR would result in failures for the implementations listed in #1852. Is the issue you're seeing on a final device or development environment? If the latter, maybe we could introduce command line options to help.

@gwawiork
Copy link
Contributor Author

gwawiork commented Mar 27, 2024

Merging this PR would result in failures for the implementations listed in #1852. Is the issue you're seeing on a final device or development environment? If the latter, maybe we could introduce command line options to help.

By default value is set as in #1852 Only when someone use reduction argument (percentage in command line) Do you use it ?
if (g_reduction_percentage != 100)

@kpet
Copy link
Contributor

kpet commented Mar 27, 2024

@gwawiork Apologies I'd missed that when quickly skimming through it. I've now approved the PR. Should be fine.

@bashbaug
Copy link
Contributor

Discussed in the April 16th teleconference. We'll give this one more week for review, but are hoping to merge shortly.

@bashbaug
Copy link
Contributor

Merging as discussed in the May 21st teleconference.

@bashbaug bashbaug merged commit b377b85 into KhronosGroup:main May 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants