Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative test for CL_INVALID_QUEUE_PROPERTIES #1935

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Negative test for CL_INVALID_QUEUE_PROPERTIES #1935

merged 1 commit into from
Jun 25, 2024

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Apr 1, 2024

Test that verifies CL_INVALID_QUEUE_PROPERTIES is returned from clCreateCommandQueue, clCreateCommandQueueWithProperties, and clCreateCommandQueueWithPropertiesKHR to match spec wording

CL_INVALID_QUEUE_PROPERTIES if values specified in properties are valid but are not supported by the device.

@EwanC EwanC mentioned this pull request Apr 1, 2024
Closed
bashbaug
bashbaug reviewed May 18, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have easy access to an implementation that does not support out-of-order queuest to test this, but I took a look through the code and it mostly LGTM.

test_conformance/api/main.cpp Outdated Show resolved Hide resolved
test_conformance/api/negative_queue.cpp Outdated Show resolved Hide resolved
@bashbaug
Copy link
Contributor

Note: there is a merge conflict that will need to be addressed also (should be straightforward).

@EwanC
Negative test for CL_INVALID_QUEUE_PROPERTIES
3e2f52f 
Test that verifies `CL_INVALID_QUEUE_PROPERTIES` is
returned from
`clCreateCommandQueue`, `clCreateCommandQueueWithProperties`, and
`clCreateCommandQueueWithPropertiesKHR` to match spec wording

> CL_INVALID_QUEUE_PROPERTIES if values specified in properties are valid but are not supported by the device.
@EwanC EwanC force-pushed the negative_queue_properties branch from 6c436ba to 3e2f52f Compare May 22, 2024 09:02
@lakshmih
Copy link
Contributor

Reviewing

@bashbaug
Copy link
Contributor

Merging as discussed in the June 25th teleconference.

@bashbaug bashbaug merged commit 8e6c519 into KhronosGroup:main Jun 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakshmih lakshmih lakshmih approved these changes

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EwanC @bashbaug @lakshmih