Added negative tests for clCommandCopy[Buffer, BufferRect, BufferToImage]KHR #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverclaw
reviewed
Apr 11, 2024
| { | ||
| CommandBufferCopyDifferentContexts(cl_device_id device, cl_context context, | ||
| cl_command_queue queue) | ||
| : BasicCommandBufferTest(device, context, queue), in_mem_ctx(nullptr), |
There was a problem hiding this comment.
You can put all these nullptr initialisers as designated initialisers on the declaration line rather than list them on the constructor which will be more cumbersome.
silverclaw
reviewed
Apr 11, 2024
| return CL_SUCCESS; | ||
| } | ||
| }; | ||
| }; |
There was a problem hiding this comment.
@silverclaw Yes, it is closing anonymous namespace, I have done it the same way as other tests are done in this directory.
silverclaw
reviewed
Apr 11, 2024
bashbaug
reviewed
May 18, 2024
test_conformance/extensions/cl_khr_command_buffer/CMakeLists.txt
Outdated
Show resolved
Hide resolved
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy.cpp
Outdated
Show resolved
Hide resolved
|
Note: there are some merge conflicts that will need to be resolved, also. |
bashbaug
previously approved these changes
May 21, 2024
EwanC
requested changes
May 21, 2024
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy.cpp
Outdated
Show resolved
Hide resolved
|
@EwanC added checking for IMAGE_SUPPORT, divided tests by copyBuffer* and copyImage func |
EwanC
reviewed
May 22, 2024
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy.cpp
Outdated
Show resolved
Hide resolved
EwanC
reviewed
May 22, 2024
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy.cpp
Outdated
Show resolved
Hide resolved
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy.cpp
Outdated
Show resolved
Hide resolved
EwanC
reviewed
May 23, 2024
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy.cpp
Show resolved
Hide resolved
EwanC
reviewed
Jun 11, 2024
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy.cpp
Show resolved
Hide resolved
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to description #1668