Negative tests for commandCopyImage[ToBuffer]KHR #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverclaw
reviewed
Apr 11, 2024
| const size_t origin[3] = { 0, 0, 0 }; | ||
| const size_t region[3] = { 512, 512, 1 }; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
@silverclaw Yes, it is closing anonymous namespace, I have done it the same way as other tests are done in this directory.
silverclaw
reviewed
Apr 11, 2024
Comment on lines
+168
to
+185
| extern int test_negative_command_buffer_copy_image_queue_not_null( | ||
| cl_device_id device, cl_context context, cl_command_queue queue, | ||
| int num_elements); | ||
| extern int test_negative_command_buffer_copy_image_context_not_same( | ||
| cl_device_id device, cl_context context, cl_command_queue queue, | ||
| int num_elements); | ||
| extern int test_negative_command_buffer_copy_image_sync_points_null_or_num_zero( | ||
| cl_device_id device, cl_context context, cl_command_queue queue, | ||
| int num_elements); | ||
| extern int test_negative_command_buffer_copy_image_invalid_command_buffer( | ||
| cl_device_id device, cl_context context, cl_command_queue queue, | ||
| int num_elements); | ||
| extern int test_negative_command_buffer_copy_image_finalized_command_buffer( | ||
| cl_device_id device, cl_context context, cl_command_queue queue, | ||
| int num_elements); | ||
| extern int test_negative_command_buffer_copy_image_mutable_handle_not_null( | ||
| cl_device_id device, cl_context context, cl_command_queue queue, | ||
| int num_elements); |
There was a problem hiding this comment.
are the extern keywords actually needed?
This is the default visibility for function declarations and thus is redundant.
There was a problem hiding this comment.
@silverclaw I have done it the same way as other tests are done in this directory.
bashbaug
changed the title
bashbaug
requested changes
May 19, 2024
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy_image.cpp
Outdated
Show resolved
Hide resolved
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy_image.cpp
Outdated
Show resolved
Hide resolved
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_copy_image.cpp
Show resolved
Hide resolved
bashbaug
approved these changes
May 21, 2024
EwanC
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to description #1668