Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: fix memory leak #1950

Merged
merged 1 commit into from
Apr 26, 2024
Merged

compiler: fix memory leak #1950

merged 1 commit into from
Apr 26, 2024

Conversation

svenvh
Copy link
Member

@svenvh svenvh commented Apr 18, 2024

The test_compiler compiler_defines_for_extensions test did not free all malloc'ed memory.

@svenvh
compiler: fix memory leak
4358973 
The `test_compiler compiler_defines_for_extensions` test did not free
all `malloc`'ed memory.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
bashbaug
bashbaug approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

We really ought to rewrite tests like these to use std::strings, but that'd be a much bigger change.

@svenvh svenvh merged commit 46255db into KhronosGroup:main Apr 26, 2024
7 checks passed
@svenvh svenvh deleted the compiler-mem-leak branch April 26, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenvh @bashbaug