Extended printf test with new strings cases #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd format string -correction to remove duplication of separate tests for each element of vector -added new sort of test to verify format string -extended previous string tests with special and nested symbols
|
Reviewing |
svenvh
requested changes
May 14, 2024
svenvh
previously approved these changes
May 20, 2024
-corrected bug in makePrintfProgram of using uninitialised name and extension -handled single printf argument use case -rearranged skip conditions in main doTest loop -clang format
svenvh
approved these changes
Jun 14, 2024
lakshmih
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to work plan from issue #1058
Corrections to general test:
-removed duplication of separate tests for each element of
PrintfTestTypevector, insteaddoTestprocedure would iterate over vector related to specificPrintfTestTypeautomaticaly-fixed procedure to assemble kernel source so it can accept only one parameter of the function ( eg.
printf("%%");)-incorporated important modifications from #1940 to avoid expected conflicts
-warnings fixes, minor corrections, clang format
Extension for string testing:
-special symbols
-nested symbols
-all ascii characters
-added new type of test
TYPE_FORMAT_STRINGto verify format string only (according to request from the issue)