Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect usage of clGetDeviceIDs num_devices #1952

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

paulfradgley
Copy link
Contributor

clGetDeviceIDs 'num_devices' output parameter is described as:

num_devices returns the number of OpenCL devices available that match device_type.

but the test_events out_of_order_event_waitlist_multi_queue_multi_device test expects that after calling:
clGetDeviceIDs(platform, CL_DEVICE_TYPE_ALL, 2, two_device_ids, &number_returned);

the content of number_returned needs to be 2, but it should be valid to return a larger number.

Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
@bashbaug
Copy link
Contributor

Merging as discussed in the June 25th teleconference.

@bashbaug bashbaug merged commit ac69311 into main Jun 25, 2024
12 of 13 checks passed
@bashbaug bashbaug deleted the paulfradgley-events-two_devices branch June 25, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants