Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build errors related with variable defined array length and gl te… #1957

Merged
merged 15 commits into from
Jul 2, 2024
Merged

Fix build errors related with variable defined array length and gl te… #1957

merged 15 commits into from
Jul 2, 2024

Conversation

jujiang-del
Copy link
Contributor

…sts logged error

svenvh
svenvh reviewed May 2, 2024
View reviewed changes
test_conformance/api/test_native_kernel.cpp Outdated Show resolved Hide resolved
test_conformance/api/test_native_kernel.cpp Outdated Show resolved Hide resolved
test_conformance/api/test_native_kernel.cpp Outdated Show resolved Hide resolved
test_conformance/api/test_native_kernel.cpp Outdated Show resolved Hide resolved
svenvh
svenvh previously approved these changes May 3, 2024
View reviewed changes
bashbaug
bashbaug reviewed May 19, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice improvement! Just a few comments.

test_conformance/gl/test_buffers.cpp Show resolved Hide resolved
test_conformance/relationals/test_shuffles.cpp Outdated Show resolved Hide resolved
@lakshmih
Copy link
Contributor

Reviewing

@bashbaug
Copy link
Contributor

bashbaug commented Jun 4, 2024

Hi @jujiang-del - did you have a chance to look at the comments above? We discussed this PR in our teleconference today and ideally they would be addressed before merging - thanks!

@jujiang-del
Copy link
Contributor Author

Thanks for the review. Updated accordingly.

bashbaug
bashbaug reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, thanks!

test_conformance/relationals/test_shuffles.cpp Outdated

generate_random_data( vecType, (unsigned int)( numOrders * inVecSize ), d, inData );
outData.clear();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed that there is one more clear here, too.

This one should change to std::fill also. Or, since the vector contents are automatically initialized to zero, I think it can be removed entirely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; I'd say it's best to rely on the default initialization and avoid unnecessary std::fill calls.

@jujiang-del
Copy link
Contributor Author

Updated. Thanks.

@neiltrevett neiltrevett merged commit 02471c8 into KhronosGroup:main Jul 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug left review comments

@svenvh svenvh svenvh approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jujiang-del @lakshmih @bashbaug @svenvh @b-sumner @neiltrevett