Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build breakage introduced by #1911 #1958

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix build breakage introduced by #1911 #1958

merged 1 commit into from
May 7, 2024

Conversation

lakshmih
Copy link
Contributor

No description provided.

@lakshmih
Copy link
Contributor Author

1911 is breaking the Android build for us, so would appreciate if this fix or an equivalent one could be reviewed and merged.

@svenvh
Copy link
Member

svenvh commented Apr 30, 2024

@okias since you authored #1911: does this proposed fix still work with your use case?

@okias
Copy link
Contributor

okias commented Apr 30, 2024

@svenvh still working properly for musl-libc, thanks for the ping!

@bashbaug
Copy link
Contributor

bashbaug commented May 7, 2024

Merging as discussed in the May 7th teleconference.

Two areas for follow-up:

  • Can we do this check in CMake, to choose the right version of strerror_r?
  • Why wasn't this break found in CI?

@bashbaug bashbaug merged commit aa70c06 into KhronosGroup:main May 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvh svenvh svenvh approved these changes

@bashbaug bashbaug Awaiting requested review from bashbaug

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lakshmih @svenvh @okias @bashbaug