relationals: fix out of bounds accesses in shuffle test #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values in `src` are indices into an array in `get_order_string()`. Not initializing `src` resulted in out of bounds accesses there. It seems that when the out of bounds accesses happened, the result of `get_order_string()` was not actually used, so at least the test was not using random data. Fix the issue as it prevents a clean run of this test with e.g. AddressSanitizer. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
aharon-abramson
approved these changes
May 26, 2024
silverclaw
approved these changes
Jun 4, 2024
paulfradgley
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values in
srcare indices into an array inget_order_string(). Not initializingsrcresulted in out of bounds accesses there.It seems that when the out of bounds accesses happened, the result of
get_order_string()was not actually used, so at least the test was not using random data. Fix the issue as it prevents a clean run of this test with e.g. AddressSanitizer.