Added new cl_khr_semaphore tests to verify clReleaseSemaphoreKHR/clRetainSemaphoreKHR negative results #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-clReleaseSemaphoreKHR -clRetainSemaphoreKHR
| // Release invalid semaphore | ||
| cl_int err = CL_SUCCESS; | ||
| err = clReleaseSemaphoreKHR(nullptr); | ||
| test_failure_error(err, CL_INVALID_SEMAPHORE_KHR, |
There was a problem hiding this comment.
Minor: this will print "expected (unknown)" because harness/errorHelpers.cpp does not know that CL_INVALID_SEMAPHORE_KHR exists.
bashbaug
previously approved these changes
Jun 28, 2024
There was a problem hiding this comment.
LGTM, other than @paulfradgley 's comment, which is more of a nice-to-have since the error message will not be printed unless the test fails.
|
2024/07/02 teleconference: @shajder Could you rebase/resolve conflicts please? |
…on for unexpected result log
bashbaug
approved these changes
Jul 9, 2024
|
Merging as discussed in memory subgroup call of July 9th 2024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to work plan from issue #1691