Strengthen testing of CL_DEVICE_TYPE query and use of CL_DEVICE_TYPE* #1977
Conversation
kamil-goras-mobica
force-pushed
the
issue_1930
branch
from
92a5282
to
9023a0c
Compare
| total_errors++; | ||
| } | ||
| test_assert_error(num_devices > 1, | ||
| "clGetDeviceIDs must return at least one device"); |
There was a problem hiding this comment.
Condition should either 'num_devices >= 1' or 'num_devices > 0' and not 'num_devices > 1'.
There was a problem hiding this comment.
@lakshmih this will be changed to ">=1"
There was a problem hiding this comment.
Do we need both the log_error and the test_assert_error? Seems redundant. Can we remove the test_assert_error case?
test_conformance/api/procs.h
Outdated
| @@ -89,6 +89,8 @@ extern int test_min_max_language_version(cl_device_id deviceID, cl_contex | |||
| extern int test_native_kernel(cl_device_id device, cl_context context, cl_command_queue queue, int n_elems ); | |||
|
|
|||
| extern int test_create_context_from_type(cl_device_id deviceID, cl_context context, cl_command_queue queue, int num_elements); | |||
| extern int test_create_context_from_type_device_type_all(cl_device_id deviceID, cl_context context, cl_command_queue queue, int num_elements); | |||
| extern int test_create_context_from_type_device_type_default(cl_device_id deviceID, cl_context context, cl_command_queue queue, int num_elements); | |||
There was a problem hiding this comment.
context_from_type goes beyond just creating the context by creating memory objects and enqueueing a kernel etc.
Should these other tests do that as welll?
num_elements seems to be unused in all cases and could be removed.
There was a problem hiding this comment.
@lakshmih No, I just wanted to create test scenarios with clCreateContextFromType with TYPE_ALL and TYPE_DEFAULT. I did not find any sufficient place so I put it here.
num_elements is needed by ADD_TEST macro
| total_errors++; | ||
| } | ||
| test_assert_error(num_devices > 1, | ||
| "clGetDeviceIDs must return at least one device"); |
There was a problem hiding this comment.
Do we need both the log_error and the test_assert_error? Seems redundant. Can we remove the test_assert_error case?
kamil-goras-mobica
force-pushed
the
issue_1930
branch
from
76229dc
to
1681bd0
Compare
|
Merging as discussed in the August 20th teleconference. |
Issue: #1930